[FFmpeg-devel] [PATCH] Channel Layout Negotiation

[Mina Nagy Zaki]

On Sun, Jun 19, 2011 at 11:14:14PM +0200, Stefano Sabatini wrote:
> On date Saturday 2011-06-18 01:58:23 +0200, Michael Niedermayer encoded:
> > On Fri, Jun 17, 2011 at 11:21:04PM +0200, Stefano Sabatini wrote:
> [...]
> > > No more comments from me, I'll apply both patches in a few days if I
> > > see no comments from other devs, maybe Michael?
> > 
> > looks fine to me too
> > 
> > thx mina and stefano
> 
> Applied, with a fix in:
> 
> commit 8f349b64813b348634042d96b9d104ada94dc538
> Author: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date:   Sun Jun 19 22:07:18 2011 +0200
> 
>     lavfi: fix realloc size computation in avfilter_add_format()
>     
>     Replace sizeof((*avff)->formats)
>     with    sizeof(*(*avff)->formats)
>     
>     as the size of the array element is given by the pointed element
>     rather than by its pointer.
>     
>     In particular fix computation with the pending patch when
>     sizeof(int64_t) != sizeof(int64_t *).
> 
> (Mina, how was you not affected by the bug?)

Ah never noticed that. I'm on a 64bit machine and so the pointer was
64bit, so no effect.