[FFmpeg-devel] [PATCH] movenc.c: fix metadata writing.

[Ronald S. Bultje]

Hi,

On Fri, Mar 4, 2011 at 2:05 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Fri, Mar 04, 2011 at 02:51:57AM +0000, M?ns Rullg?rd wrote:
>> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>>
>> > Fix metadata writing, broken in commit:
>> > 0abdb2931719d96dee725e555e9b46b2b2f8a6be
>> > because some characters in the string are >=0x80 and therefore the
>> > shift on characters in the fourcc broke down because of sign extension.
>>
>> Wouldn't it be better to fix those shifts?
>
> Fixing MKTAG still would be a rather good idea...

I'm not sure if MKTAG() is broken. It doesn't specify signedness or
range of the input characters.

Ronald