[FFmpeg-devel] [PATCH] avio: add avio_tell macro as a replacement for url_ftell

[Michael Niedermayer]

On Fri, Mar 04, 2011 at 11:27:13AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Mar 3, 2011 at 2:11 PM, Anton Khirnov <anton at khirnov.net> wrote:
> > ---
> > ?ffmpeg.c ? ? ? ? ? ? ? ? ? ? | ? ?4 +-
[...]
> > ?87 files changed, 392 insertions(+), 391 deletions(-)
> 
> Queued.

I told you that a macro is worse for this kind of changes.
revert this!

Before this patch (function)
     -rw-r--r-- 1 michael michael 1102630 Mar  5 03:41 libavformat.a

After this patch (macro)
     -rw-r--r-- 1 michael michael 1105846 Mar  5 03:38 libavformat.a

you made libavformat as a whole 0.3% bigger
for what? to randomly change functions to macros without the slightest reason?

and yeah its just 0.3% but thats the 4th or 5th such silly macro patch.
After all of them are applied it will be alot more than 0.3%
what fantastic incompetence. In a few month ffmpeg will be twice as big and
half the speed if this way of patch "review" continues.

just calculate 0.3% per week for a few years

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110305/9b0b30e5/attachment.pgp>