[FFmpeg-devel] [ffmpeg-patch] DCA Encoder

[Ivan Kalvachev]

Just few 2 nitpicks from me, without actually looking at the code.

On 3/21/11, Stefano Sabatini <stefano.sabatini-lala at poste.it> wrote:
> On date Monday 2011-03-21 19:36:15 +0800, xiang wang encoded:
>> Hi
>>
>> First patch is DCA Encoder,
>>
>> the second added 5.1 supports and code revision to DCA Enc.  Thanks:)
>
>> From 5370628e1b70f2d7c5525d8e8ef7de19770946f0 Mon Sep 17 00:00:00 2001
>> From: Xiang <xiangwang.job at gmail.com>
>> Date: Mon, 21 Mar 2011 19:14:42 +0800
>> Subject: [PATCH 1/2] DCA Encoder
>>
>> ---
>>  libavcodec/Makefile    |    1 +
>>  libavcodec/allcodecs.c |    1 +
>
>>  libavcodec/dcaenc.c    |  569
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>  libavcodec/dcaenc.h    |  569
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 1140 insertions(+), 0 deletions(-)
>>  create mode 100644 libavcodec/dcaenc.c
>>  create mode 100644 libavcodec/dcaenc.h
>>
>> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
>> index 04e35a1..a56f721 100644
>> --- a/libavcodec/Makefile
>> +++ b/libavcodec/Makefile
>> @@ -103,6 +103,7 @@ OBJS-$(CONFIG_COOK_DECODER)            += cook.o
>>  OBJS-$(CONFIG_CSCD_DECODER)            += cscd.o
>>  OBJS-$(CONFIG_CYUV_DECODER)            += cyuv.o
>>  OBJS-$(CONFIG_DCA_DECODER)             += dca.o synth_filter.o dcadsp.o
>> +OBJS-$(CONFIG_DCA_ENCODER)             += dcaenc.o

Does this allow enabling only the encoder without the decoder?
I would think that we can have a little redundancy here.
The very next DNXHD codec do duplicate common objects.

>>  OBJS-$(CONFIG_DNXHD_DECODER)           += dnxhddec.o dnxhddata.o
>>  OBJS-$(CONFIG_DNXHD_ENCODER)           += dnxhdenc.o dnxhddata.o       \
>>                                            mpegvideo_enc.o motion_est.o \
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 8de6ad8..b2fac11 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -237,6 +237,7 @@ void avcodec_register_all(void)
>>      REGISTER_DECODER (BINKAUDIO_RDFT, binkaudio_rdft);
>>      REGISTER_DECODER (COOK, cook);
>>      REGISTER_DECODER (DCA, dca);
>> +    REGISTER_ENCDEC  (DCA, dca);

I think that ENCDEC includes the decoder, so it should replace the
DECODER (the line above)