[FFmpeg-devel] [PATCH] libswcale: PIX_FMT_BGR48LE and PIX_FMT_BGR48BE scaler implementation

Michael Niedermayer michaelni at gmx.at
Fri Mar 18 14:28:57 CET 2011


On Fri, Mar 18, 2011 at 10:57:35PM +1100, Peter Ross wrote:
> ---
> On Thu, Mar 17, 2011 at 08:38:22PM +0100, Reimar Döffinger wrote:
> > On 17 Mar 2011, at 15:16, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > On Thu, Mar 17, 2011 at 09:20:30PM +1100, Peter Ross wrote:
> > >> ---
> > >> libswscale/swscale.c          |   49 +++++++++++++++++++++++++++++++++++++++++
> > >> libswscale/swscale.h          |    2 +-
> > >> libswscale/swscale_internal.h |   10 ++++++-
> > >> libswscale/swscale_template.c |    7 ++++++
> > >> libswscale/utils.c            |    2 +
> > >> libswscale/yuv2rgb.c          |   12 ++++++++++
> > >> 6 files changed, 79 insertions(+), 3 deletions(-)
> > >
> > > LGTM if tested
> 
> Yep, BGR48LE has been tested with the Phantom Cine demuxer (work in progress)
> BGR48BE has been tested using synthesised input.
> 
> > Shouldn't it rather use one of the av_asserts instead of just assert?
> 
> The asserts are removed in patch below. They are not needed, src2 is never used.

still LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110318/8f7cabb8/attachment-0001.asc>


More information about the ffmpeg-devel mailing list