[FFmpeg-devel] [PATCH] vf_fade: draw_slice() chroma fade check determines existence of lama plain

Stefano Sabatini stefano.sabatini-lala at poste.it
Fri Mar 18 17:44:00 CET 2011


On date Friday 2011-03-18 14:42:29 +0000, Mark Himsley encoded:
> draw_slice() checks that planes 0 and 1 of AVFilterBufferRef's data
> are not null before manipulating planes 1 and 2. This patch makes
> the check against planes 1 and 2.
> 
> -- 
> Mark

> diff --git a/libavfilter/vf_fade.c b/libavfilter/vf_fade.c
> index 203a186..4a8f617 100644
> --- a/libavfilter/vf_fade.c
> +++ b/libavfilter/vf_fade.c
> @@ -114,7 +114,7 @@ static void draw_slice(AVFilterLink *inlink, int y, int h, int slice_dir)
>              }
>          }
>  
> -        if (outpic->data[0] && outpic->data[1]) {
> +        if (outpic->data[1] && outpic->data[2]) {
>              /* chroma planes */
>              for (plane = 1; plane < 3; plane++) {
>                  for (i = 0; i < h; i++) {

LGTM, equivalent but possibly more robust.

I'll apply soon if nobody beats me at it, thanks.
-- 
FFmpeg = Fascinating Fast Mega Purposeless Educated Gem



More information about the ffmpeg-devel mailing list