[FFmpeg-devel] [PATCH 1/4] Support reference picture defined by bitmask in MJPEG's SOS decoder

[Anatoly Nenashev]

On 31.03.2011 14:58, Michael Niedermayer wrote:
> On Mon, Mar 28, 2011 at 12:01:40AM +0400, Anatoly Nenashev wrote:
>    
>>      
> [...]
>
>    
>>       }
>>
>> -    if(s->interlaced&&  s->bottom_field)
>> -        data += linesize>>  1;
>> +    if(s->interlaced&&  s->bottom_field) {
>> +        int offset = linesize>>  1;
>> +        data += offset;
>> +        reference_data += offset;
>> +    }
>>      
> This doesnt fit together with:
>    
>> +                if (jpg->interlaced) {
>> +                    av_log(avctx, AV_LOG_ERROR, "Interlaced mode not supported in MxPEG\n");
>> +                    return AVERROR(EINVAL);
>> +                }
>>      
> do interlaced mxpeg exist / is it allowed?
> if so it should be supported, if not theres no need to partially
> implement it
>
> Not a major issue but it seems inconsistent
>    
>

Hmm... Interlaced mode is not supported in Mobotix's SDK for MxPEG and 
progressive mode too. I don't know if they will be implemented later. 
So, you right, I will remove this parts from code.

Anatoly.