[FFmpeg-devel] postprocess.c: filter name needs to be double 0 terminated

Michael Niedermayer michaelni at gmx.at
Sat May 28 22:22:34 CEST 2011

On Sat, May 28, 2011 at 07:24:41PM +0200, Piotr Kaczuba wrote:
> Since the switch from strncpy() to av_strlcpy() in  
> pp_get_mode_by_name_and_quality() in libpostproc/postprocess.c (commit  
> 1a5e4fd8c5b99478b4e08a69261930bb12aa948b), the replacement of short  
> filter names doesn't work any more. The way the replacement algorithm  
> works, it requires that the whole filter name string be double 0  
> terminated. Strncpy() took care of that quasi automatically by filling  
> the remainder of the buffer with zeroes, but av_strlcpy() does not. In  
> the case of mplayer, the error message is:
> $ mplayer -vf pp a.avi
> ...
> Opening video filter: [pp]
> 1 errors in postprocess string "de"
> ...
> Attached patch fixes it.
> -- 
> Cheers,
> Piotr

>  postprocess.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 8b38d13cb2d1fe73b25d2bf4f7e664f0cada33f3  postprocess.diff

applied, thx


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110528/ac03aa51/attachment.asc>

More information about the ffmpeg-devel mailing list