[FFmpeg-devel] [PATCH 1/2] vble: move the sign calculation to vble_unpack()

[Derek Buitenhuis]

On 13/11/2011 9:24 PM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer<michaelni at gmx.at>
> ---
>   libavcodec/vble.c |    8 +++++---
>   1 files changed, 5 insertions(+), 3 deletions(-)

Looks fine, but what exactly is the reason for this?

> +        if (ctx->val[i]){

Needs a space before the {.

> +            int v = (1<<  ctx->val[i]) + get_bits(gb, ctx->val[i]) - 1;

I'd personally prefer that the declarations all be at the beginning
of the function.

- Derek