[FFmpeg-devel] [PATCH 1/2] mpeg12: raise timecode string to codec context.

[Michael Niedermayer]

On Wed, Nov 16, 2011 at 05:52:33PM +0100, Clément Bœsch wrote:
> From: Clément Bœsch <clement.boesch at smartjog.com>
> 
> ---
>  doc/APIchanges       |    3 +++
>  libavcodec/avcodec.h |    7 +++++++
>  libavcodec/mpeg12.c  |   10 ++++++----
>  libavcodec/version.h |    2 +-
>  4 files changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 8a2a9de..cc72063 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -13,6 +13,9 @@ libavutil:   2011-04-18
>  
>  API changes, most recent first:
>  
> +2011-11-xx - xxxxxxx - lavc 53.35.0
> +  Add timecode string (timecode_str) to AVCodecContext.
> +
>  2011-11-03 - 96949da - lavu 51.23.0
>    Add av_strcasecmp() and av_strncasecmp() to avstring.h.
>  
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index d62cbfb..88ebbad 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -2679,6 +2679,13 @@ typedef struct AVCodecContext {
>       */
>      int64_t timecode_frame_start;
>  
> +    /**
> +     * Codec timecode string
> +     * - encoding: unused
> +     * - decoding: set by libavcodec
> +     */
> +    char timecode_str[16];
> +
>  #if FF_API_REQUEST_CHANNELS

adding it in the middle can cause ABI issues
also a note saying that it should only be accessed via av_opt*
would avoid ABI issues if it moves
char [16] might not work well with av_opt though


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111116/6080f7c6/attachment.asc>