[FFmpeg-devel] [PATCH 13/16] vqavideo: check for out of bound reads.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Oct 9 01:52:08 CEST 2011


On Sun, Oct 09, 2011 at 01:12:07AM +0200, Michael Niedermayer wrote:
> On Sun, Oct 09, 2011 at 12:28:27AM +0200, Reimar Döffinger wrote:
> > On Sat, Oct 08, 2011 at 11:40:38PM +0200, fenrir at elivagar.org wrote:
> > > +            if (src_pos + count >dest_size)
> > > +            if (src_pos + count >dest_size)
> > 
> > Missing space after >
> 
> are you ok if i apply patches that just fail such cosmetic issues and
> you or whoever cares fixes it afterwards?
> 
> Because IMHO its more work if a new patch has to be sent for this
> than if someone just fixes it and commits/pushes ...

Well, it would be quickest if whoever commits just puts in those spaces.
Because I won't remember it (there's still that piece of code that
should be using FFALIGN I keep forgetting about and no longer even
remember where it is) and it just won't get done.


More information about the ffmpeg-devel mailing list