[FFmpeg-devel] [PATCH] Correct buffer handling for RTCP packets

Michael Niedermayer michaelni at gmx.at
Wed Oct 12 23:39:36 CEST 2011

On Wed, Oct 12, 2011 at 12:53:12AM -0600, John Brooks wrote:
> Previous code could read 4 bytes past the end of the buffer on a RTCP_SR
> packet or offset a pointer by an unchecked external value (payload_len),
> though neither will reliably cause a crash or other misbehavior beyond
> garbage timestamps.
> Additionally, unknown RTCP packet types, even in compounded packets, are
> now ignored as per RFC 3550 section 6.1, page 22, though currently this
> only has any practical effect if a sender puts an unrecognized type
> before RTCP_BYE in a compounded packet, or (incorrectly) does not put
> RTCP_SR first.
> Signed-off-by: John Brooks <john.brooks at bluecherry.net>
> ---
>  libavformat/rtpdec.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)

applied, thanks

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111012/2b368896/attachment.asc>

More information about the ffmpeg-devel mailing list