[FFmpeg-devel] [PATCH] mpegtsenc: fix free of adts when not using AAC

[Michael Niedermayer]

On Wed, Oct 12, 2011 at 09:59:44PM -0500, Chris Kennedy wrote:
> On Wed, Oct 12, 2011 at 10:18:22PM +0000, Carl Eugen Hoyos wrote:
> > Chris Kennedy <bitbytebit <at> gmail.com> writes:
> > 
> > > There is a free for the adts data in writing the trailer onto mpegts
> > > files, yet it is only allocated when we are using AAC.  I have seen
> > > backtraces that point to this as the issue, although it oddly only
> > > segfaults on a very rare occasion.
> > 
> > Please upload the sample that triggers the segfault for you.
> 
> It's actually from a live stream from a clearQAM mpegts broadcast,
> so unfortunately has been impossible to get a file that triggers it.
> It's rare, once every week, and when it happens backtraces always
> point into libavformat somewhere from either the write trailer 
> function or read frame function.  Here's the two backtraces I've
> gotten, always seems to be when closing an output context and opening
> a new one for mpegts.  

if you cannot upload a sample then maybe running the stuff under
valgrind might point more clearly to the cause

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111019/711a5f3a/attachment.asc>