[FFmpeg-devel] codec_names.sh and #ifdefs

Michael Niedermayer michaelni at gmx.at
Sat Oct 22 16:54:51 CEST 2011


On Sat, Oct 22, 2011 at 11:31:15AM +0200, Nicolas George wrote:
> Le decadi 30 vendémiaire, an CCXX, Michael Niedermayer a écrit :
> > codec_names.sh doesnt work when there are #ifs (for example checking
> > ABI version in the enum list)
> > 
> > Nicolas (or someone else) do you have time to look into this?
> 
> I came up with the attached patch. The principle of the change is to call
> $(CC) -E avcodec.h from the makefile and pipe it to the script, and it seems
> to work: it fixes the error when LIBAVCODEC_VERSION_MAJOR is set to 54. I
> could not test it on a wide variety of platforms though.
> 
> It has a slight drawback: in the brief output, the generation is written as:
> "CC libavcodec/codec_names.h" instead of GEN. I think this is acceptable
> (and my opinion is that brief output should be implemented as an option in
> make rather than ugly and hackish constructs in makefiles; but I digress).

patch applied, thanks alot

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111022/49c7cf45/attachment.asc>


More information about the ffmpeg-devel mailing list