[FFmpeg-devel] [PATCH] libmp3lame: log error message in case of invalid number of channels

Stefano Sabatini stefasab at gmail.com
Fri Oct 28 18:47:07 CEST 2011


Also return meaningful error number in place of -1.
Improve feedback.
---
 libavcodec/libmp3lame.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c
index fcefa29..c364d2b 100644
--- a/libavcodec/libmp3lame.c
+++ b/libavcodec/libmp3lame.c
@@ -49,8 +49,11 @@ static av_cold int MP3lame_encode_init(AVCodecContext *avctx)
 {
     Mp3AudioContext *s = avctx->priv_data;
 
-    if (avctx->channels > 2)
-        return -1;
+    if (avctx->channels > 2) {
+        av_log(avctx, AV_LOG_ERROR,
+               "Invalid number of channels %d > 2\n", avctx->channels);
+        return AVERROR(EINVAL);
+    }
 
     s->stereo = avctx->channels > 1 ? 1 : 0;
 
-- 
1.7.4.1



More information about the ffmpeg-devel mailing list