[FFmpeg-devel] [RFC] Simplify avfilter_get_audio_buffer()

[Michael Niedermayer]

On Sun, Sep 11, 2011 at 01:42:03PM +0200, Stefano Sabatini wrote:
> On date Sunday 2011-09-11 11:22:51 +0200, Stefano Sabatini encoded:
> > On date Wednesday 2011-08-31 22:28:58 +0200, Michael Niedermayer encoded:
> [...]
> > > > From 06d86b94545d1d0a8d191a61a06e9c9c00edb6eb Mon Sep 17 00:00:00 2001
> > > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > > Date: Tue, 30 Aug 2011 23:22:29 +0200
> > > > Subject: [PATCH] lavfi: simplify signature for avfilter_get_audio_buffer() and friends
> > > > 
> > > > The additional parameters were never used and are complicating the
> > > > function interface. Also, they're inconsistent with the way the video
> > > > API works.
> > > > 
> > > > So this assumes that a requested samples buffer will have *always* the
> > > > format specified in the requested link.
> > > > 
> > > > This breaks API and ABI, so it will require a major bump.
> > > 
> > > iam not sure this needs a major bump
> > > not even ffmpeg.c used it yet, so id almost tend to say this is a
> > > non issue ABI wise
> > 
> > Correct, I'm going to push this soon.
> 
> And patch.
> -- 
> FFmpeg = Frightening Furious Mean Portable Ermetic Guru

>  doc/APIchanges             |    4 ++++
>  libavfilter/af_aresample.c |    5 +----
>  libavfilter/avfilter.c     |   14 +++++---------
>  libavfilter/avfilter.h     |   17 ++++++-----------
>  libavfilter/defaults.c     |   25 ++++++++++---------------
>  libavfilter/src_movie.c    |    4 +---
>  6 files changed, 27 insertions(+), 42 deletions(-)
> f34d81a1a81b91f762444c6ae8ddd1acfc495f29  0005-lavfi-simplify-signature-for-avfilter_get_audio_buff.patch
> From 5d2a22b47d0070bf3900bc5082c2f72aabfc3e24 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Tue, 30 Aug 2011 23:22:29 +0200
> Subject: [PATCH] lavfi: simplify signature for avfilter_get_audio_buffer() and friends
> 
> The additional parameters were never used and are complicating the
> function interface. Also, they were inconsistent with the way the
> video API works.
> 
> So this assumes that a requested samples buffer will have *always* the
> format specified in the requested link.

no objection

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110912/794e38db/attachment.asc>