[FFmpeg-devel] [PATCH]Use colon in "Stream: #"

[Stefano Sabatini]

On date Thursday 2011-09-22 14:12:47 +0200, Carl Eugen Hoyos encoded:
> On Tuesday 20 September 2011 02:42:41 pm Stefano Sabatini wrote:
> > On date Tuesday 2011-09-20 00:34:00 +0200, Michael Niedermayer encoded:
> > > On Mon, Sep 19, 2011 at 11:25:52PM +0200, Carl Eugen Hoyos wrote:
> > > >
> > > > I believe this improves the situation with -map.
> > >
> > > iam happy with any punctuation that people like
> > 
> > But then you have:
> > Stream #0:0: Video: flv1, yuv420p, 320x240, 29.97 tbr, 1k tbn, 1k tbc
> > 
> > the repeated ":" is a bit confusing
> 
> Would you prefer attached?
> 
> Carl Eugen

> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index ee62000..3047545 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -3460,7 +3460,7 @@ static void dump_stream_format(AVFormatContext *ic, int i, int index, int is_out
>      int g = av_gcd(st->time_base.num, st->time_base.den);
>      AVDictionaryEntry *lang = av_dict_get(st->metadata, "language", NULL, 0);
>      avcodec_string(buf, sizeof(buf), st->codec, is_output);
> -    av_log(NULL, AV_LOG_INFO, "    Stream #%d.%d", index, i);
> +    av_log(NULL, AV_LOG_INFO, "    Stream #%d:%d", index, i);
>      /* the pid is an important information, so we display it */
>      /* XXX: add a generic system */
>      if (flags & AVFMT_SHOW_IDS)
> @@ -3468,7 +3468,7 @@ static void dump_stream_format(AVFormatContext *ic, int i, int index, int is_out
>      if (lang)
>          av_log(NULL, AV_LOG_INFO, "(%s)", lang->value);
>      av_log(NULL, AV_LOG_DEBUG, ", %d, %d/%d", st->codec_info_nb_frames, st->time_base.num/g, st->time_base.den/g);
> -    av_log(NULL, AV_LOG_INFO, ": %s", buf);
> +    av_log(NULL, AV_LOG_INFO, ", %s", buf);
>      if (st->sample_aspect_ratio.num && // default
>          av_cmp_q(st->sample_aspect_ratio, st->codec->sample_aspect_ratio)) {
>          AVRational display_aspect_ratio;

Uhm, that would be:

Stream #0:0, Video: flv1, yuv420p, 320x240, 29.97 tbr, 1k tbn, 1k tbc

I'd rather expect:
Stream #0:0: Video, flv1, yuv420p, 320x240, 29.97 tbr, 1k tbn, 1k tbc

as the media type ("Video") is a property belonging to the stream
#0:0.

So I did my mind and I prefer the "#0:0:" variant, although it is
slightly confusing.
-- 
FFmpeg = Fascinating Friendly Mortal Portable Elastic Guide