[FFmpeg-devel] [PATCH 3/4] mxf: Add two codec ULs for V210

Michael Niedermayer michaelni at gmx.at
Tue Sep 27 22:26:01 CEST 2011


On Tue, Sep 27, 2011 at 01:07:22PM -0700, Baptiste Coudurier wrote:
> On 9/27/11 2:40 AM, Tomas Härdin wrote:
> > On Tue, 2011-09-27 at 02:23 -0700, Baptiste Coudurier wrote:
> >> Hi Thomas,
> >>
> >> On 9/27/11 2:13 AM, Tomas Härdin wrote:
> >>>
> >>>
> >>> 0003-mxf-Add-two-codec-ULs-for-V210.patch
> >>>
> >>>
> >>> From 1dabdaea6a1f41d2e210dd6e2ef6bd48c1d96bbc Mon Sep 17 00:00:00 2001
> >>> From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <tomas.hardin at codemill.se>
> >>> Date: Mon, 26 Sep 2011 11:24:11 +0200
> >>> Subject: [PATCH 3/4] mxf: Add two codec ULs for V210
> >>>
> >>> ---
> >>>  libavformat/mxf.c |    2 ++
> >>>  1 files changed, 2 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/libavformat/mxf.c b/libavformat/mxf.c
> >>> index 1b85a89..ad384f2 100644
> >>> --- a/libavformat/mxf.c
> >>> +++ b/libavformat/mxf.c
> >>> @@ -43,6 +43,8 @@ const MXFCodecUL ff_mxf_codec_uls[] = {
> >>>      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x02,0x01,0x7F,0x00,0x00,0x00 }, 13,   CODEC_ID_RAWVIDEO }, /* Uncompressed */
> >>>      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x02,0x02,0x03,0x02,0x00,0x00 }, 14,      CODEC_ID_DNXHD }, /* SMPTE VC-3/DNxHD */
> >>>      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x02,0x01,0x32,0x00,0x00 }, 14,       CODEC_ID_H264 }, /* H.264/MPEG-4 AVC Intra */
> >>> +    { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x02,0x01,0x01,0x02,0x02,0x02 }, 16,       CODEC_ID_V210 }, /* V210 */
> >>> +    { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x01,0x01,0x02,0x02,0x01 }, 16,       CODEC_ID_V210 }, /* V210 */
> >>
> >> It seems that only 15 bytes are relevant, and version should be ignored,
> >> I think there is a function that does this already.
> > 
> > Ah, you're right - mxf_match_uid() ignores the version byte. Updated
> > patch attached.
> > 
> > /Tomas
> > 
> > 
> > 0003-mxf-Add-PictureEssenceCoding-UL-for-V210.patch
> > 
> > 
> > From 2c0d4d0f44f5e8cf42d0f5faaff465e0b0cdfce6 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <tomas.hardin at codemill.se>
> > Date: Mon, 26 Sep 2011 11:24:11 +0200
> > Subject: [PATCH 3/4] mxf: Add PictureEssenceCoding UL for V210
> > 
> > ---
> >  libavformat/mxf.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavformat/mxf.c b/libavformat/mxf.c
> > index 1b85a89..b39a9b6 100644
> > --- a/libavformat/mxf.c
> > +++ b/libavformat/mxf.c
> > @@ -43,6 +43,7 @@ const MXFCodecUL ff_mxf_codec_uls[] = {
> >      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x02,0x01,0x7F,0x00,0x00,0x00 }, 13,   CODEC_ID_RAWVIDEO }, /* Uncompressed */
> >      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x02,0x02,0x03,0x02,0x00,0x00 }, 14,      CODEC_ID_DNXHD }, /* SMPTE VC-3/DNxHD */
> >      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x02,0x01,0x32,0x00,0x00 }, 14,       CODEC_ID_H264 }, /* H.264/MPEG-4 AVC Intra */
> > +    { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x01,0x01,0x02,0x02,0x00 }, 15,       CODEC_ID_V210 }, /* V210 */
> >      /* SoundEssenceCompression */
> >      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x02,0x02,0x01,0x00,0x00,0x00,0x00 }, 13,  CODEC_ID_PCM_S16LE }, /* Uncompressed */
> >      { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x02,0x02,0x01,0x7F,0x00,0x00,0x00 }, 13,  CODEC_ID_PCM_S16LE },
> > 
> 
> Looks good to me.

applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/bc493a1c/attachment.asc>


More information about the ffmpeg-devel mailing list