[FFmpeg-devel] [PATCH] ppc bswap (WR 1.9)

[Michael Niedermayer]

On Wed, Sep 28, 2011 at 09:12:56PM +0200, Reimar Döffinger wrote:
> 
> 
> On 28 Sep 2011, at 20:51, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Hi
> > 
> > Patch below is from wunderadio 1.9 i have no means to test this
> > Author is unknown
> > 
> > 
> > diff -wru ./libavutil/bswap.h /home/michael/wunderadio/WR1.9/ffmpeg//libavutil/bswap.h
> > --- ./libavutil/bswap.h 2011-09-20 17:25:06.739577809 +0200
> > +++ /home/michael/wunderadio/WR1.9/ffmpeg//libavutil/bswap.h    2009-02-06 02:32:39.000000000 +0100
> > @@ -40,6 +40,31 @@
> > #   include "x86/bswap.h"
> > #endif
> > 
> > +
> > +#ifdef __APPLE__
> > +#include <TargetConditionals.h>
> > +#if (TARGET_IPHONE_SIMULATOR == 0) && (TARGET_OS_IPHONE == 1)
> 
> Huh? iPhone surely isn't PPC, and if it's an ARM optimisation the condition is nonsense.
> In addition this seems already properly implemented in arm/bswap.h

#ifdef APPLE must have confused me :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110928/586dda8b/attachment.asc>