[FFmpeg-devel] [PATCH] Add AVIO_FLAG_DIRECT.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Apr 1 20:09:13 CEST 2012


On Sun, Apr 01, 2012 at 12:11:29PM +0200, Michael Niedermayer wrote:
> On Wed, Mar 28, 2012 at 10:26:35PM +0200, Reimar Döffinger wrote:
> > Allows avoiding the buffer when using avio read and write functions.
> > The test does not work: It works for testing reading, but for
> > writing avio_flags never gets set in the ffmpeg.c part of the change.
> 
> what works, LGTM

I can't parse that answer.
Should I commit even though setting the flag for writing and thus
testing doesn't work?
There is also another strange thing: while it works with -avioflags
direct, fate-svq3 breaks when initializing direct to 1 in
ffio_init_context.
To be more precise, FFmpeg claims the file does not contain any streams.
Strangely, this seems to be related to the seeking function, commenting
out any of the !s->direct conditions there fixes it, as well as not
setting s->direct but instead disabling the first two cases otherwise
breaks it.
I think that last code path should be working in any and all (except
non-seekable stream) cases, right?


More information about the ffmpeg-devel mailing list