[FFmpeg-devel] [PATCH 2/2] lavc: add MicroDVD decoder.

[Clément Bœsch]

On Sun, Apr 15, 2012 at 11:08:39PM +0200, Reimar Döffinger wrote:
> On Sun, Apr 15, 2012 at 10:55:52PM +0200, Clément Bœsch wrote:
> > On Sun, Apr 15, 2012 at 10:50:03PM +0200, Clément Bœsch wrote:
> > > On Sun, Apr 15, 2012 at 10:46:26PM +0200, Reimar Döffinger wrote:
> > > > On Sun, Apr 15, 2012 at 07:51:01PM +0200, Clément Bœsch wrote:
> > > > > On Sun, Apr 15, 2012 at 07:38:05PM +0200, Reimar Döffinger wrote:
> > > > > > On Sat, Apr 14, 2012 at 09:47:22PM +0200, Clément Bœsch wrote:
> > > > > > > Ported from MPlayer.
> > > > > > 
> > > > > > Looking at the code I'm quite sure there is no real issue
> > > > > > and I know we've used that wording before, but I find
> > > > > > "ported" a bit misleading/confusing when adding LGPL
> > > > > > code that is "ported" from a GPL project.
> > > > > 
> > > > > "Ported and relicensed" then?
> > > > 
> > > > That's worse! "Relicense" is implies you contacted all
> > > > the authors of the code and got permission to make it
> > > > LGPL.
> > > > I don't know what exactly you want to say with "ported",
> > > > so I can hardly say explicitly what to write.
> > > > "The MPlayer implementation was used as reference."
> > > > possibly, but I don't know how exactly you used the
> > > > MPlayer code.
> > > 
> > > Well, AFAIK I'm the only author of the MicroDVD code in MPlayer, so I
> > 
> > MicroDVD conversion code to ASS I mean (sub/subassconvert.c). Maybe I
> > should mention it?
> 
> Yes, if you meant only the MicroDVD->ASS conversion code

Yes, I basically copied the MicroDVD→ASS conversion code from
sub/subassconvert.c and glue with FFmpeg stuff.

> that's something different, I didn't quite get it.
> I would have gone for "Based on my MicroDVD->ASS conversion code in
> MPlayer". Mentioning the file name wouldn't hurt though either.

Then, consider the description locally fixed into "Based on my
MicroDVD->ASS conversion code from MPlayer (sub/subassconvert.c)".

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120415/fb2b0ad3/attachment.asc>