[FFmpeg-devel] [PATCH] CrystalHD: fix pStride value and set aspect ratio

[Philip Langdale]

On Apr 17, 2012, at 3:51, Michael Niedermayer <michaelni at gmx.at> wrote:

> On Tue, Apr 17, 2012 at 10:17:27AM +0200, Istvan Sebok wrote:
>> 2012. április 16. 20:33 Istvan Sebok írta, <sebok.istvan at gmail.com>:
>> 
>>> 
>>> 
>>> 2012. április 16. 0:49 Reimar Döffinger írta, <Reimar.Doeffinger at gmx.de>:
>>> 
>>> On Mon, Apr 16, 2012 at 12:18:44AM +0200, Istvan Sebok wrote:
>>>>> 2012. április 15. 22:48 Reimar Döffinger írta, <
>>>> Reimar.Doeffinger at gmx.de>:
>>>>> 
>>>>>> On Sun, Apr 15, 2012 at 09:13:15PM +0200, Istvan Sebok wrote:
>>>>>>> 
>>>>>> 
>>>>>> A bit more of a description wouldn't hurt.
>>>>>> Are you absolutely sure the 1080 pStride value actually works?
>>>>>> 1080 would be a very, very strange value for a supported
>>>>>> video width.
>>>>>> 
>>>>> 
>>>>> I didn't add 1080 pStride value I just changed 'else if' order. I have
>>>>> 70015 card, I can't test it.
>>>> 
>>>> Well, from the code behaviour point changing the else if order has
>>>> the same effect as adding it.
>>>> Without someone to test, removing it would be safer than changing
>>>> the order.
>>>> 
>>>> 
>>> OK. I wait few days. If nobody tests it, I will remove these lines and I
>>> will send a new patch.
>>> 
>>> 
>>> Scott D. Davilla helped for me, he wrote:
>> 
>> The 70015 card provides a correct stride but the 70012 card is stride
>> quantized to 720/1280/1920
>> 
>> The new patch fix warning: "'pStride' may be used uninitialized in this
>> function" too.
> 
> maintainer added to CC, just to make sure its not missed
> the patches look fine to me but i dont know the code nor do i have
> hardware to test

Looks fine. Thanks for catching that stride bug.

--phil