[FFmpeg-devel] [PATCH 0/3] 3GPP TS 26.245 Timed Text Encoder. (v2)

[Philip Langdale]

On Thu, 26 Jul 2012 20:37:50 -0700
Philip Langdale <philipl at overt.org> wrote:

> This patch series introduces support for encoding subtitles as 3GPP
> timed text into mp4/mov containers. As with the decoder, there's no
> styling support currently.
> 
> Note that this feature requires a change to the actual muxer to
> handle the insertion of empty packets to signify the end of a subtitle
> duration.
> 
> Also note that one of the most common use-cases (remuxing from mkv to
> mp4) will not work yet, as the subtitle duration is put in the
> convergence_duration by the mkv demuxer. We still need to resolve this
> matter and decide whether it is appropriate to use
> convergence_duration at all, and if so, how to cleanly reconcile the
> use of both fields.
> 
> I'm also throwing in a related change to fix the srt demuxer to write
> package durations. Without this, you cannot mux an external subtitle
> into an mp4 file (or most other containers).
> 
> Philip Langdale (3):
>   movtextenc: 3GPP TS 26.245 Timed Text Encoder.
>   movenc: Handle need for extra packets to express subtitle duration.
>   avformat/srtdec: Write duration into packet from srt demuxer.
> 
>  Changelog               |    2 +-
>  doc/general.texi        |    2 +-
>  libavcodec/Makefile     |    1 +
>  libavcodec/allcodecs.c  |    2 +-
>  libavcodec/movtextenc.c |  162
> +++++++++++++++++++++++++++++++++++++++++++++++
> libavcodec/version.h    |    2 +- libavformat/movenc.c    |   88
> +++++++++++++++++++++++-- libavformat/movenc.h    |    1 +
>  libavformat/srtdec.c    |   19 ++++--
>  9 files changed, 263 insertions(+), 16 deletions(-)
>  create mode 100644 libavcodec/movtextenc.c
> 

Clément had minor comments that I've addressed. Does anyone else have
comments or intends to review it? I'd like to push this weekend
otherwise.

Thanks,

--phil