[FFmpeg-devel] [PATCH] lavc/old_codec_ids: Fix make checkheaders.

Alexander Strasser eclipse7 at gmx.net
Wed Aug 8 01:44:12 CEST 2012


Hi,

  thanks for the patch.

jamal wrote:
> common.h defines MKBETAG() and includes attributes.h

  including both would probably be more robust against
future change. The common.h header pulls in lots of
stuff but it is possible this gets changed in the
future.

  No strong opinion for this instance of the problem.

  Alexander


> ---
>  libavcodec/old_codec_ids.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libavcodec/old_codec_ids.h b/libavcodec/old_codec_ids.h
> index a163205..1c8d88e 100644
> --- a/libavcodec/old_codec_ids.h
> +++ b/libavcodec/old_codec_ids.h
> @@ -19,7 +19,7 @@
>  #ifndef AVCODEC_OLD_CODEC_IDS_H
>  #define AVCODEC_OLD_CODEC_IDS_H
>  
> -#include "libavutil/attributes.h"
> +#include "libavutil/common.h"


More information about the ffmpeg-devel mailing list