[FFmpeg-devel] [PATCH] [SOCIS] [WIP] libavfilter: add vf_hue.c

Jérémy TRAN tran.jeremy.av at gmail.com
Fri Aug 10 22:47:57 CEST 2012


Thanks for the reviews !

2012/8/6 Nicolas George <nicolas.george at normalesup.org>:
>> +static av_cold int init(AVFilterContext *ctx, const char *args)
>> +{
>> +    HueContext *hue = ctx->priv;
>> +    float h, s;
>> +
>> +    if (args)
>> +        sscanf(args, "%f:%f", &h, &s);
>> +
>> +    if (h < 0 || h > 360 || s < 0 || s > 2) {
>
> Is there any reason to limit the angle.

Well since it allows the user to express any angle I thought it was
fine like that, but yes we could also remove the limit.

-- 
Jérémy Tran
ACU 2013
EPITA GISTRE 2013


More information about the ffmpeg-devel mailing list