[FFmpeg-devel] [PATCH] libavfilter: add vf_hue.c

[Clément Bœsch]

On Sat, Aug 11, 2012 at 01:20:45AM +0200, Stefano Sabatini wrote:
[...]
> > +} HueContext;
> > +
> > +static av_cold int init(AVFilterContext *ctx, const char *args)
> > +{
> > +    HueContext *hue = ctx->priv;
> > +    float h, s;
> > +
> 
> > +    if (args)
> > +        sscanf(args, "%f:%f", &h, &s);
> 
> I tend to prefer the use of named options, despite the fact of
> breaking compatibility with mp=hue, because of the increased
> robustness/flexibility/overall consistency.
> 
> What's the opinion of other devs?
> 

Given the name of the filter, I don't think much more options will be
added. A more generic filter handling other equalizer parameters such as
brightness or contrast would have required it, but in that particular case
I wonder if that matters much...

> Alternatively we could try to support both syntaxes (check how it is
> done in buffersrc).
> 

Why not but in that case it could be done later I guess.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120811/c57ed9bf/attachment.asc>