[FFmpeg-devel] [PATCH] libavfilter: add vf_hue.c

Stefano Sabatini stefasab at gmail.com
Sat Aug 11 20:59:04 CEST 2012


On date Saturday 2012-08-11 12:05:31 +0200, Nicolas George encoded:
> Le quintidi 25 thermidor, an CCXX, Stefano Sabatini a écrit :
> > I'm fine with it if people insist with syntax backward compatibility,
> > with the possibility to extend it later. If it turns out too complex
> > to maintain both syntaxes I suggest to deprecate and drop this one.
> 
> I would like to suggest that (and I am willing to implement it if it is
> deemed a good idea)
> 
> /**
>  * Equivalent to av_set_options_string(obj, args, "=", ":"),
>  * except that if the first fields in args do not have the '=' char, then
>  * the options are set in order: the first field sets the first option, the
>  * second field sets the second (distinct) option, etc.
>  */

> int av_set_options_string(void *obj, char *args);

This is the name of an already used function (and we should try to
honour the av_opt_ prefixing with new functions -
av_opt_set_spec_string() maybe an idea).

> It would make an interesting short syntax for a lot of filters. The API
> could be refined, so that maybe only a few very important options would be
> eligible for short syntax.

The main drawback in this case is that it would make the option order
relevant (so you can't sort options by name in the array), unless we
provide a secondary list of pointers to options.

That's not a serious issue, and indeed supporting short options
specification could be useful.
-- 
FFmpeg = Fostering and Fiendish Majestic Perfectionist Evil Gadget


More information about the ffmpeg-devel mailing list