[FFmpeg-devel] [PATCH] Interlaced encoding for ProRes

Michael Niedermayer michaelni at gmx.at
Sun Aug 12 19:09:57 CEST 2012


Hi

On Fri, Aug 10, 2012 at 03:30:51PM +0200, Boris Maksalov wrote:
> Hi,
> 
> I've implemented interlaced encoding for ProRes.
> To activate interlaced mode, pass -flags +ildct
> 
> The first patch fixes a pre-existing bug where incomplete macroblocks were partially filled with memory read past the end of frame buffer. This can be verified with valgrind. The second patch actually implements interlaced encoding.
> 
> I do realize 'prores_kostya' encoder originates from libav and I did contact its author first, but things are moving quite slow on the libav side, so I am submitting my patches here.

interlaced prores encoding support is welcome on the ffmpeg side.
I would have preferred it in anatolies encoder though as i dont want to
compete with kostya in maintaining his encoder but that wont stop me
from applying a patch that adds an important feature.

What stoped me though is that 
your patch breaks "make fate", this is a problem and has to be fixed
first.
the 2nd patch is ok and applied though

a fate/regression test for the interlaced case should be added as well

thanks

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120812/b051988a/attachment.asc>


More information about the ffmpeg-devel mailing list