[FFmpeg-devel] [PATCH] build: check for perl presence and compile POD pages only in that case

Stefano Sabatini stefasab at gmail.com
Mon Aug 13 12:25:35 CEST 2012


On date Monday 2012-08-13 07:41:01 +0200, Clément Bœsch encoded:
> On Sat, Aug 11, 2012 at 12:01:18PM +0200, Stefano Sabatini wrote:
[...]
> > diff --git a/doc/Makefile b/doc/Makefile
> > index 723b05e..3fe6921 100644
> > --- a/doc/Makefile
> > +++ b/doc/Makefile
> > @@ -12,9 +12,10 @@ HTMLPAGES   = $(PROGS-yes:%=doc/%.html)                                 \
> >  TXTPAGES    = doc/fate.txt                                              \
> >  
> >  
> > -DOCS-$(HAVE_TEXI2HTML)  += $(HTMLPAGES)
> > -DOCS-$(HAVE_POD2MAN)    += $(MANPAGES) $(PODPAGES)
> > -DOCS-$(HAVE_MAKEINFO)   += $(TXTPAGES)
> > +DOCS-$(CONFIG_HTMLPAGES) += $(HTMLPAGES)
> > +DOCS-$(CONFIG_PODPAGES)  += $(PODPAGES)
> > +DOCS-$(CONFIG_MANPAGES)  += $(MANPAGES)
> > +DOCS-$(CONFIG_TXTPAGES)  += $(TXTPAGES)
> >  DOCS = $(DOCS-yes)
> >  
> >  all-$(CONFIG_DOC): documentation
> > @@ -53,7 +54,7 @@ $(DOCS): | doc/
> >  
> >  install-man:
> >  
> > -ifdef HAVE_POD2MAN
> > +ifdef CONFIG_MANPAGES
> 
> won't that be always defined?

No, check config.mak.

> [...]
> 
> The rest LGTM if tested, thanks.

Pushed, thanks for the review.
-- 
FFmpeg = Fast Fierce Murdering Programmable Emblematic Gem


More information about the ffmpeg-devel mailing list