[FFmpeg-devel] [PATCH] Fix filters permissions

Stefano Sabatini stefasab at gmail.com
Thu Aug 16 17:45:16 CEST 2012


On date Thursday 2012-08-16 16:55:03 +0200, Nicolas George encoded:
> Le decadi 30 thermidor, an CCXX, Stefano Sabatini a écrit :
> > Is there a special reason for which NEG_LINESIZES is not used?
> 
> Yes: it is not really a permission in the sense: something the filter is
> allowed to do with the buffer. In fact, it is the opposite of a permission:
> if it is present, the filter is not allowed to assume positive linesize.

I remember I disliked the negative logic, but was the simpler way to
do it (no need to modify all filters), dunno if it is a good idea to
change it now (but: compatibility break).

[...]
> > Looks good otherwise, of course assuming it has been tested.
> 
> I ran FATE, it covers the most useful parts of it. If you have other tests
> you want to suggest, I will run them.

Feel free to push in that case, but please comment on the rej_persm in
outlink filters remark.
-- 
FFmpeg = Fascinating and Fundamental Magic Perennial Encoding/decoding Game


More information about the ffmpeg-devel mailing list