[FFmpeg-devel] [PATCH] ffmpeg: reduce differences with avconv for in/out scheduling.

Michael Niedermayer michaelni at gmx.at
Sun Aug 19 04:48:37 CEST 2012


On Sat, Aug 18, 2012 at 05:34:53PM +0200, Nicolas George wrote:
> Rework the transcode() function and its immediate annexes to have
> the same structure as in avconv, while still maintaining proper
> scheduling to avoid accumulation.

It may be interresting to note that this does not reduce the diff to
avconv

 qatar/master:avconv.c => HEAD^:ffmpeg.c | 1576 ++++++++++++++++++++++---------
 1 file changed, 1138 insertions(+), 438 deletions(-)
 qatar/master:avconv.c => HEAD:ffmpeg.c | 1591 +++++++++++++++++++++++---------
 1 file changed, 1148 insertions(+), 443 deletions(-)


 
> 
> Using -filter_complex without inputs now works.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  ffmpeg.c |  287 ++++++++++++++++++++++++++++++++------------------------------
>  1 file changed, 146 insertions(+), 141 deletions(-)
> 
> 
> This time with -shortest working.
> 
> 
> diff --git a/ffmpeg.c b/ffmpeg.c
> index 860499a..78758b0 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -947,16 +947,19 @@ static void do_video_stats(AVFormatContext *os, OutputStream *ost,
>      }
>  }
>  
> -/* check for new output on any of the filtergraphs */
> -static int poll_filters(void)
> +/**
> + * Check for new output on any of the filtergraphs, without causing activity.
> + *

This description is a bit terse, the code does more than just check

otherwise very nice work, thanks and LGTM!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120819/edf93c61/attachment.asc>


More information about the ffmpeg-devel mailing list