[FFmpeg-devel] [PATCH 2/3] ffplay: replace SDL_delay in read thread with SDL_CondWait

Michael Niedermayer michaelni at gmx.at
Thu Aug 30 01:00:02 CEST 2012


On Thu, Aug 30, 2012 at 12:10:06AM +0200, Marton Balint wrote:
> When the audio queue was empty, it was not filled until the 10ms delay expired
> in the read thread. This patch changes the delay method with a condition wait,
> which reacts to an empty queue a lot faster, therefore the audio buffer
> underruns become less common especially after seeking.
> 
> Signed-off-by: Marton Balint <cus at passwd.hu>

LGTM

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120830/f6956375/attachment.asc>


More information about the ffmpeg-devel mailing list