[FFmpeg-devel] [PATCH] lavf/vsrc: switch to ff_filter_frame.

Clément Bœsch ubitux at gmail.com
Sat Dec 1 01:29:46 CET 2012


---
I just followed the change made to mandelbrot; I'm unsure about two things:
 - is it safe to remove the ref/unref?
 - should we raise the result of ff_filter_frame in these request_frame
   callbacks instead?
---
 libavfilter/vsrc_cellauto.c  | 6 +-----
 libavfilter/vsrc_life.c      | 6 +-----
 libavfilter/vsrc_mptestsrc.c | 6 +-----
 3 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/libavfilter/vsrc_cellauto.c b/libavfilter/vsrc_cellauto.c
index 27a4d18..06d9f9a 100644
--- a/libavfilter/vsrc_cellauto.c
+++ b/libavfilter/vsrc_cellauto.c
@@ -319,11 +319,7 @@ static int request_frame(AVFilterLink *outlink)
 #ifdef DEBUG
     show_cellauto_row(outlink->src);
 #endif
-
-    ff_start_frame(outlink, avfilter_ref_buffer(picref, ~0));
-    ff_draw_slice(outlink, 0, cellauto->h, 1);
-    ff_end_frame(outlink);
-    avfilter_unref_buffer(picref);
+    ff_filter_frame(outlink, picref);
 
     return 0;
 }
diff --git a/libavfilter/vsrc_life.c b/libavfilter/vsrc_life.c
index ebe6cc2..d8b8355 100644
--- a/libavfilter/vsrc_life.c
+++ b/libavfilter/vsrc_life.c
@@ -439,11 +439,7 @@ static int request_frame(AVFilterLink *outlink)
 #ifdef DEBUG
     show_life_grid(outlink->src);
 #endif
-
-    ff_start_frame(outlink, avfilter_ref_buffer(picref, ~0));
-    ff_draw_slice(outlink, 0, life->h, 1);
-    ff_end_frame(outlink);
-    avfilter_unref_buffer(picref);
+    ff_filter_frame(outlink, picref);
 
     return 0;
 }
diff --git a/libavfilter/vsrc_mptestsrc.c b/libavfilter/vsrc_mptestsrc.c
index fa41e68..d526ee2 100644
--- a/libavfilter/vsrc_mptestsrc.c
+++ b/libavfilter/vsrc_mptestsrc.c
@@ -355,11 +355,7 @@ static int request_frame(AVFilterLink *outlink)
     }
 
     test->frame_nb++;
-
-    ff_start_frame(outlink, avfilter_ref_buffer(picref, ~0));
-    ff_draw_slice(outlink, 0, picref->video->h, 1);
-    ff_end_frame(outlink);
-    avfilter_unref_buffer(picref);
+    ff_filter_frame(outlink, picref);
 
     return 0;
 }
-- 
1.8.0.1



More information about the ffmpeg-devel mailing list