[FFmpeg-devel] [PATCH] lavc/dvdsubdec: accept palette from options.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Dec 1 17:09:52 CET 2012

On Sat, Dec 01, 2012 at 04:09:59PM +0100, Nicolas George wrote:
> On DVDs, the palette is part of the IFO file and therefore
> not available when reading from a dumped VOB file.

Usually you would copy the IFO as well.
I guess making FFmpeg use that IFO might be more difficult
than just adding this option though.

> +    if ((ret = dvdsub_parse_extradata(avctx)) < 0)
> +        return ret;
> +
> +    if (ctx->palette_str)
> +        parse_palette(ctx, ctx->palette_str);

Why not allowing to set the size as well, i.e. just use the extradata
text format 1:1? (which of course leads to the question if we shouldn't
just have an option to set/replace the extradata).
Also, why refuse to init when the extradata parsing fails but we have
have all the info?
Though it seems that right now dvdsub_parse_extradata can't fail anyway.
I'm not sure that it's a good idea to have a return value if it's not
used anyway.

More information about the ffmpeg-devel mailing list