[FFmpeg-devel] [PATCH 2/2] iff demuxer: include DEEP TVDC lookup table in extradata buffer

[Peter Ross]

On Sat, Dec 01, 2012 at 08:52:16AM +0100, Reimar Döffinger wrote:
> On Sat, Dec 01, 2012 at 05:41:31PM +1100, Peter Ross wrote:
> > +            if ((res = avio_read(pb, iff->tvdc, sizeof(iff->tvdc))) < 0)
> 
> I guess I won't be able to convince you, but I can't stop myself
> from say that munging this all into a single line IMHO is really
> bad for readability, the assignment could just as well be in its own
> line.

Sounds fair. I will fix that.

> >  #include "libavutil/avutil.h"
> >  
> >  #define LIBAVFORMAT_VERSION_MAJOR 54
> > -#define LIBAVFORMAT_VERSION_MINOR 41
> > -#define LIBAVFORMAT_VERSION_MICRO 100
> > +#define LIBAVFORMAT_VERSION_MINOR 42
> > +#define LIBAVFORMAT_VERSION_MICRO 0
> 
> But my real comment is that the our micro version by policy starts at
> 100, to distinguish from Libav.

Okay.

If there are no other objections, I will push in 24 hrs.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121203/d5b8b56c/attachment.asc>