[FFmpeg-devel] [PATCH] IRCAM demuxer

[Daniel Verkamp]

On Mon, Dec 3, 2012 at 6:07 AM, Paul B Mahol <onemda at gmail.com> wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  doc/general.texi         |   1 +
>  libavformat/Makefile     |   1 +
>  libavformat/allformats.c |   1 +
>  libavformat/ircamdec.c   | 141 +++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 144 insertions(+)

See http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2010-April/081161.html
and responses (never checked in).

A few things that may be worth copying:
- comment metadata
- codec bit_rate, but maybe that is automatically determined for PCM?
- stronger probe

> +    if (!!le) {
> +        sample_rate = av_int2float(avio_rl32(s->pb));
> +        channels    = avio_rl32(s->pb);
> +        encoding    = avio_rl32(s->pb);
> +    } else if (!le) {
> +        sample_rate = av_int2float(avio_rb32(s->pb));
> +        channels    = avio_rb32(s->pb);
> +        encoding    = avio_rb32(s->pb);
> +    } else {
> +        return AVERROR_INVALIDDATA;
> +    }

The else seems unlikely. :)

-- Daniel Verkamp