[FFmpeg-devel] [PATCH] IRCAM demuxer

[Paul B Mahol]

On 12/4/12, Daniel Verkamp <daniel at drv.nu> wrote:
> On Mon, Dec 3, 2012 at 6:07 AM, Paul B Mahol <onemda at gmail.com> wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  doc/general.texi         |   1 +
>>  libavformat/Makefile     |   1 +
>>  libavformat/allformats.c |   1 +
>>  libavformat/ircamdec.c   | 141
>> +++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 144 insertions(+)
>
> See http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2010-April/081161.html
> and responses (never checked in).
>

Yes, unfortuantely i get aware of it _after_ sending this.

> A few things that may be worth copying:
> - comment metadata
> - codec bit_rate, but maybe that is automatically determined for PCM?

It is automatically determined.
> - stronger probe

Already done + codec tags

>
>> +    if (!!le) {
>> +        sample_rate = av_int2float(avio_rl32(s->pb));
>> +        channels    = avio_rl32(s->pb);
>> +        encoding    = avio_rl32(s->pb);
>> +    } else if (!le) {
>> +        sample_rate = av_int2float(avio_rb32(s->pb));
>> +        channels    = avio_rb32(s->pb);
>> +        encoding    = avio_rb32(s->pb);
>> +    } else {
>> +        return AVERROR_INVALIDDATA;
>> +    }
>
> The else seems unlikely. :)

It is still possible.

BTW I plan to push muxer and demuxer soon.