[FFmpeg-devel] [PATCH]Accept 0 as codec_tag in ffmpeg.c if it matches the codec_id

[Michael Niedermayer]

On Sun, Dec 09, 2012 at 02:47:34PM +0100, Carl Eugen Hoyos wrote:
> On Saturday 08 December 2012 03:02:39 am Michael Niedermayer wrote:
> > On Fri, Dec 07, 2012 at 01:15:21PM +0100, Carl Eugen Hoyos wrote:
> > > Hi!
> > >
> > > Attached patch fixes ticket #1953 for me.
> > >
> > > I suspect the actual problem is that av_codec_get_tag() returns 0 both in
> > > case of failure and success, but that seems difficult to fix without
> > > breaking API.
> >
> > i think we should add a new function that is free of this ambiguity
> 
> New patch attached.
> 
> Please review, Carl Eugen

breaks fate also some of the changes from the old tp the new function
look wrong. I dont think all the == 0 checks meant failure some
actually meant the 0 tag

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121211/e4b0aa7e/attachment.asc>