[FFmpeg-devel] [PATCH] thp: set duration

Paul B Mahol onemda at gmail.com
Tue Dec 18 18:40:08 CET 2012


On 12/17/12, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 17/12/2012 3:34 PM, Paul B Mahol wrote:
>>>> applied
>>>
>>> Excuse me?
>>>
>>> You have pushed it whilst completely ignoring my reviews. You have not
>>> even provided an explanation. This is incredibly rude and
>>> unprofessional.
>>>
>>> I don't think this sort of behavior is acceptable in a collaborative
>>> environment.
>>>
>>> Perhaps you can expand on why?
>>
>> Many demuxers use number of frames in stream as stream duration.
>>
>> If you do not like current state post patch that address this by using
>> nb_frames to set duration (similar how it is done for bitrate). This
>> would also factorize some code.
>
> It's all well and fine that the patch was technically correct (for reasons
> other
> than you listed here, actually), but that does not make it OK to disregard
> others'
> reviews entirely and apply things without explanation or even the courtesy
> to nte
> why. That is -extremely- rude and unprofessional, and very counterproductive
> in
> creating a collaborative environment for development.

Counterproductive and time consuming are reviews and rants as
demonstrated in this and
another thread.

I ignore and will ignore such demonstration of bad faith.


More information about the ffmpeg-devel mailing list