[FFmpeg-devel] [PATCH] astenc: Add an option to set the loop flag

[James Almer]

On 12/12/12 7:14 PM, jamal wrote:
> On 12/12/12 5:46 PM, Carl Eugen Hoyos wrote:
>>> On 12/12/12 6:19 AM, Carl Eugen Hoyos wrote:
>>>> I wondered if values like "-1" cannot be used to indicate 
>>>> "no loop"?
>>
>>> In which option you mean using -1? Either loopend or loopstart?
>>
>> Yes, either one of them or both.
>>
>>> That seems less intuitive than
>>> an option that's essentially "Enable loop"...
>>
>> If you think so, please ignore my comment, I 
>> just wanted to share my initial thoughts.
>>
>> Carl Eugen
> 
> Another problem is that you could give one a -1 value but an actual value to the other.
> Which would take priority in such case?
> 
> I personally prefer adding an option to enable the flag, which is much more clear for 
> the end user.
> 
> I'm attaching an updated patch that doesn't reindent lines as you requested, and with 
> an added extra warning.
> 
> Regards.

Ping.