[FFmpeg-devel] [PATCH] libavcodec: add h.264 dxva2 decoder to ffmpeg

[Xidorn Quan]

On Thu, Dec 27, 2012 at 7:50 PM, compn <tempn at twmi.rr.com> wrote:
>>On Thu, 27 Dec 2012 12:54:32 +0800, Wei Gao wrote:
>>>2012/12/26 Hendrik Leppkes <h.leppkes at gmail.com>
>>The purpose we add the wrappers is that, we want to submit VC1,wmv3,mpeg2
>>dxva2 code.so the other video format can reuse the code.Sorry that it may
>>add more maintenance.But I think it is convenient for users who want to use
>>dxva2.As you said,DXVA2 has many parameters.so if we supply a API for
>>users,they can call it easier rather than write it from start.This is our
>>opinion.Thanks.
>
> i was thinking the wrapper would be used in mplayer.

I made vda work in mplayer by the same method, and I don't think it is
a bad idea. IMHO, wrappers of hwaccels significantly simplify coding
in downstream players like mplayer, and they also enable ffmpeg itself
to use hardware accelerating when decoding videos.

>>>And another point, a lot of the code seems to be copy/pasted from VLC,
>>>without attribution to the original authors.
>>
>>Yes, I copy the VLC code, I will write the attribution later.Sorry for that.
>>
>>Thank you for your reply.We will fix our patch and submit soon.Thank you
>>very much.
>
> i wonder if vlc would be interested in dropping thier copy of the code
> if it were merged into ffmpeg.

I agree with you.

-- 
Xidorn Quan