[FFmpeg-devel] [PATCH] vf_tinterlace: add vertical low-pass-filter option to mode 4 and 5

Stefano Sabatini stefasab at gmail.com
Sun Dec 30 15:22:50 CET 2012


On date Saturday 2012-12-29 23:32:45 +0000, Mark Himsley encoded:
> On 29/12/2012 09:52, Stefano Sabatini wrote:
> > remove "up to two" in case we add more options
> > Better to put the possible values inside the @item description.
> > Nit: "low_pass_filter flag ignored with mode %d\n"
> 
> I think I've done what you requested with the doc, I assume the
> @var{mode} values will be moved inside its @item description in a later
> patch - so it matches the @var{flags}. Or I've got the wrong end of the
> stick.
> 
> > LGTM otherwise, thanks.
> 
> Thank you for your review. It is better code now.
> 
> 
> Low-pass filtering is required when creating an interlaced destination
> from a progressive source which contains high-frequency vertical detail.
> Filtering will reduce interlace 'twitter' and Moire patterning.
> 
> Updated patch attached.
[...]

Applied with some documentation tweaks, and an alias "vlfp" for
"low_filter_pass", thank you.
-- 
FFmpeg = Frightening and Fast Mortal Political Elaborated Gargoyle


More information about the ffmpeg-devel mailing list