[FFmpeg-devel] [PATCH 2/2] lavd/lavfi: support all sample formats.

[Nicolas George]

Le tridi 3 ventôse, an CCXX, Stefano Sabatini a écrit :
> I confess I never did, I was waiting for big-endian people to complain
> and provide a patch ;-).

Well, I did not either, but I suspect the new code is slightly more lilely
to work.

> What happens if codec is set to NONE?, should never happen but an
> assert / error message may be useful for debugging/documentation
> purposes.

Currently, the device inits correctly, but ffmpeg fails with:

Decoder (codec none) not found for input stream #0:1

But it works if the audio stream with unknown codec is not used.

I added the following message:

             st->codec->channel_layout = link->channel_layout;
+            if (st->codec->codec_id == CODEC_ID_NONE)
+                av_log(avctx, AV_LOG_ERROR,
+                       "Could not find PCM codec for sample format %s.\n",
+                       av_get_sample_fmt_name(link->format));
         }

but no actual failure, I think this is correct.

> Looks fine, thanks and sorry for the slow reply.

No problem. I will push this version very soon.

Did you look at the aconvert issue?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120221/5001d95d/attachment.asc>