[FFmpeg-devel] [PATCH]Fix progressive jpgs with weird pix_fmts

Michael Niedermayer michaelni at gmx.at
Sat Jan 7 03:27:52 CET 2012


On Sat, Jan 07, 2012 at 03:17:36AM +0100, Carl Eugen Hoyos wrote:
> On Saturday 07 January 2012 02:59:06 am Michael Niedermayer wrote:
> > > Attached fixes the samples from ticket #892 for me.
> > >
> > > Please comment, Carl Eugen
> > 
> > reset upscale* otherwise this is possibly exploitable if the width or
> > height or "pix_fmt" changes
> 
> As in attached?

not enough

1st frame sets upscale_h
2nd frame changes width/height and branches via -1 from ff_mjpeg_find_marker
to the_end

also wherever the variables are reset i suggest that a av_assert0 is
added to make sure the pixel format matches the expectation that is
theres enough space for chroma

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120107/049c2e00/attachment.asc>


More information about the ffmpeg-devel mailing list