[FFmpeg-devel] [PATCH] ffprobe: print error in main() rather than in probe_file()

[Stefano Sabatini]

On date Friday 2012-01-06 22:13:21 +0100, Clément Bœsch encoded:
> On Fri, Jan 06, 2012 at 09:44:45PM +0100, Stefano Sabatini wrote:
> [...]
> > On the other hand I'm not so sure this is a good idea, possibly
> > -show_error should be used *only* for reporting probing file errors
> > (rather than - inconsistently - syntax errors), so this may be changed
> > to:
> > 
> >        else {
> >            ret = probe_file(wctx, input_filename);
> >            if (ret < 0 && do_show_error)
> >                show_error(wctx, ret);
> >        }
> > 
> 
> Indeed, I tend to agree with this; only the probing errors should be
> printed in that section, the command mis-usage doesn't belong here (and
> isn't helpful anyway for anything IMO). The documentation might be
> clarified on that point BTW.

Applied this variant.
-- 
FFmpeg = Fierce Fancy Magic Puristic Encoding/decoding Game