[FFmpeg-devel] [PATCH] CDXL demuxer and decoder

[Reimar Döffinger]

On 7 Jan 2012, at 23:19, Paul B Mahol <onemda at gmail.com> wrote:
> On 1/7/12, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
>> On 7 Jan 2012, at 21:06, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>>> Reimar Doeffinger <Reimar.Doeffinger <at> gmx.de> writes:
>>> 
>>>> On 7 Jan 2012, at 20:52, Paul B Mahol <onemda <at> gmail.com> wrote:
>>>>> On 12/30/11, Reimar Doeffinger <Reimar.Doeffinger <at> gmx.de> wrote:
>>>>>> only partial review...
>>>>>>> +            AV_WL32(out + (x * 4), (0xFF << 24) | (r | g | b));
>>> 
>>>> I don't know which, but there is for example both RGBA and RGB32 (I think
>>>> RGB32 is it).
>>> 
>>> Since the codec does not support transparency (iiuc), RGB24 and 0RGB32 are
>>> also
>>> possible options.
>> 
>> Oh. Yes, without transparency RGB24 and writing the values bytes-wise
>> instead of first combining them into 32 bit should be better.
> 
> That would make CDXL RGB decoding support via PAL8 pixfmt broken.

Just use two different functions to read the palette or some such.
Even if you don't want to do that I don't see how changing PIX_FMT to RGB24 and WL32 to
out[3*x] = r;
out[3*x+1] = g >> 8;
out[3*x+2] = b >> 16;
and nothing else should break the PAL8 code that is in a different place.