[FFmpeg-devel] [PATCH]Add some v4l raw codecs

[Luca Abeni]

Hi all,

first of all, sorry for the late reply.
On Mon, 2012-01-02 at 17:16 +0100, Michael Niedermayer wrote:
> On Mon, Jan 02, 2012 at 05:02:10PM +0100, Carl Eugen Hoyos wrote:
> > Hi!
> > 
> > I tested attached on Intel hardware, and it makes me wonder if the existing 
> > RGB15 and RGB16 mappings are correct...
> > 
> > The order of fmt_conversion_table[] also seems strange to me, less bpp is 
> > preferred over more bpp. Should this be changed?
> 
> maybe
> 
> 
> > Finally, passing fourccs instead of pix_fmts would allow to support YV12.
> 
> > Is it a bug that libswscale does not remove transparency for RGB0 -> RGBA?
> 
> bug, please open a ticket
> 
> 
> > Or should the user (application) realize that this is not a useful conversion?
> > 
> > Please comment, Carl Eugen
> 
> LGTM, luca ?
When I wrote the original mapping between libav pixelformats and v4l2
formats, I could not test all of the entries, and some of them were
based on information I asked on the mailing list. So, some entries might
be wrong (even because the pixelformats somehow changed in the
meantime).
I also agree about the ordering issue, so I think the patch is ok.


				Luca