[FFmpeg-devel] [PATCH 2/2] mpeg12dec: BW10 support

[Michael Niedermayer]

On Sat, Jan 14, 2012 at 01:20:08PM +0100, Reimar Döffinger wrote:
> On Fri, Jan 13, 2012 at 11:55:07PM +0100, Michael Niedermayer wrote:
> > On Fri, Jan 13, 2012 at 08:46:42PM +0100, Reimar Döffinger wrote:
> > > On Fri, Jan 13, 2012 at 05:57:30AM +0100, Michael Niedermayer wrote:
> > > > @@ -2268,7 +2273,10 @@ static int mpeg_decode_frame(AVCodecContext *avctx,
> > > >              return buf_size;
> > > >      }
> > > >  
> > > > -    if (s->mpeg_enc_ctx_allocated == 0 && avctx->codec_tag == AV_RL32("VCR2"))
> > > > +    s2->codec_tag = avpriv_toupper4(avctx->codec_tag);
> > > 
> > > IMO this needs some explaining comment, particularly since riff.c
> > > contains only the uppercase variant, so how would a lowercase one
> > > end up here?
> > 
> > this uppercasing is done for all mpegvideo codecs in MPV_common_init()
> > but that is called from, vcr2_init_sequence()
> > it seemed to make sense for sake of consistency to do it the same way
> > here ...
> 
> Well, probably, but then if I'm pedantic it does not really belong
> into this patch but is rather unrelated?

split and applied
Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120114/1fb84e03/attachment.asc>