[FFmpeg-devel] [PATCH] XWD decoder and encoder

[Carl Eugen Hoyos]

Paul B Mahol <onemda <at> gmail.com> writes:

> +            pal[i] = (0xFF << 24) | (red << 16) | (green << 8) | blue;

It was suggested here to use "0xFFU" (and the braces are unneeded iirc).

[...]

> +                avctx->pix_fmt = be ? PIX_FMT_ARGB : PIX_FMT_BGRA;

> +                avctx->pix_fmt = be ? PIX_FMT_ABGR : PIX_FMT_RGBA;

This should be 0RGB, BGR0, 0BGR and RGB0.

Thank you, Carl Eugen