[FFmpeg-devel] [PATCH 2/2] cafdec: replace deprecated get_strz()

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Jan 23 19:29:15 CET 2012


On Mon, Jan 23, 2012 at 04:24:38PM +0000, Carl Eugen Hoyos wrote:
> Paul B Mahol <onemda <at> gmail.com> writes:
> 
> > -        get_strz(pb, key, sizeof(key));
> > -        get_strz(pb, value, sizeof(value));
> > +        avio_get_str(pb, sizeof(key), key, sizeof(key));
> > +        avio_get_str(pb, sizeof(value), value, sizeof(value));
> 
> Patch applied.

get_strz is implemented as
avio_get_str(pb, INT_MAX, buf, buf_size)
though, which shows different behaviour.
Are you really, really sure that your code is
correct and won't actually break decoding of some files
with extremely long strings?


More information about the ffmpeg-devel mailing list